Add tests for new FieldSet object#1998
Merged
VeckoTheGecko merged 12 commits intov4-devfrom May 6, 2025
Merged
Conversation
Will be accessed directly from the xarray metadata
Remove usage of setattr
VeckoTheGecko
commented
May 2, 2025
Contributor
Author
There was a problem hiding this comment.
Any more tests we should have in here @fluidnumerics-joe ? (even if its just stubs def test_my_thing():... so that we don't forget them later)
Contributor
|
Taking a look right after the elphe meeting this morning |
fluidnumericsJoe
requested changes
May 5, 2025
Contributor
fluidnumericsJoe
left a comment
fluidnumericsJoe
left a comment
There was a problem hiding this comment.
Just a couple minor changes
Contributor
Author
I've responded now :)
Let me know if anything comes to mind. Good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v4-devfor v4 changes)Changes:
_parent_meshreprsinto a separate fileFieldSet.add_fieldfieldset.constants(avoids call tosetattr)FieldSet.__getattr__FieldSet.add_constant_field